Discussion:
[Gerbv-devel] Rotation still broken... without warning?
Clemens Koller
2017-02-10 10:51:25 UTC
Permalink
Hi there!

I am currently reviewing some paste masks and want to rotate the board data containing some arbitrary pad shapes.
After a 90° rotation, the center points of some (rasterized) pads gets transformed properly, but the pad orientation itself
stays the same which breaks things.

If this happens, I would at least expect a warning that the design data may be corrupt after such a transformation.
Better would be a proper fix.

I could provide some test data. Is there anybody working on a fix already? I am willing to help to improve this part.

Regards,

Clemens
Uwe Bonnes
2017-02-10 11:30:26 UTC
Permalink
Clemens> Hi there! I am currently reviewing some paste masks and want
Clemens> to rotate the board data containing some arbitrary pad shapes.
Clemens> After a 90° rotation, the center points of some (rasterized)
Clemens> pads gets transformed properly, but the pad orientation itself
Clemens> stays the same which breaks things.

Clemens> If this happens, I would at least expect a warning that the
Clemens> design data may be corrupt after such a transformation. Better
Clemens> would be a proper fix.

Clemens> I could provide some test data. Is there anybody working on a
Clemens> fix already? I am willing to help to improve this part.

Are you working with git master? On a first and second look the panel I did
with my recent patches
https://sourceforge.net/p/gerbv/bugs/216/
https://sourceforge.net/p/gerbv/feature-requests/91/
and containing a rotated design looks right.

Bye
--
Uwe Bonnes ***@elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 1623569 ------- Fax. 06151 1623305 ---------
Clemens Koller
2017-02-10 13:13:53 UTC
Permalink
Hi, Uwe!
Post by Uwe Bonnes
Are you working with git master? On a first and second look the panel I did
with my recent patches
https://sourceforge.net/p/gerbv/bugs/216/
https://sourceforge.net/p/gerbv/feature-requests/91/
and containing a rotated design looks right.
Uaha... it's some "2.6.1"-something compiled from git on Oct. 21 2016.

Maybe it's really time for a release just to avoid possibly-already-fixed-bug reports?

When I go the easy way, feeding gerbv in goo, I end up with:
https://sourceforge.net/projects/gerbv/files/
which shows it's modified 2014-10-30...
gerbv-2.6.1 is dated 2013-07-22, gerbv-beta is from 2016-07-13

Who is in charge which I can handle over a big broom here to update the websites and get rid of that old stuff?

I'll retest when I get a chance to rebuild it...
Maybe a better approach is: release early, release often?

Regards,

Clemens
Post by Uwe Bonnes
Clemens> Hi there! I am currently reviewing some paste masks and want
Clemens> to rotate the board data containing some arbitrary pad shapes.
Clemens> After a 90° rotation, the center points of some (rasterized)
Clemens> pads gets transformed properly, but the pad orientation itself
Clemens> stays the same which breaks things.
Clemens> If this happens, I would at least expect a warning that the
Clemens> design data may be corrupt after such a transformation. Better
Clemens> would be a proper fix.
Clemens> I could provide some test data. Is there anybody working on a
Clemens> fix already? I am willing to help to improve this part.
Are you working with git master? On a first and second look the panel I did
with my recent patches
https://sourceforge.net/p/gerbv/bugs/216/
https://sourceforge.net/p/gerbv/feature-requests/91/
and containing a rotated design looks right.
Bye
Patrick Franken
2017-02-10 14:25:43 UTC
Permalink
As I stated during FOSDEM I’d be interested in helping on a new Gerbv release. As I’m quite new in this project, where should we start such a discussion? I could put some time in as my company heavily relies on Gerbv.
From my experience a new Gerbv release would heavily help non software engineering people to use Gerbv, thus increase popularity. We had the same situation with KiCAD which had no proper release for years but nightlies from different sources. After the 4.0 release people actually knew what to use.

Patrick
Post by Clemens Koller
Who is in charge which I can handle over a big broom here to update the websites and get rid of that old stuff?
I'll retest when I get a chance to rebuild it...
Maybe a better approach is: release early, release often?
Clemens Koller
2017-02-12 11:58:36 UTC
Permalink
Hello, Patrick, Sergey!
As I stated during FOSDEM I’d be interested in helping on a new Gerbv release.
I've seen that one video as well... 8-)
As I’m quite new in this project, where should we start such a discussion?
Here? Sergey, what do you think?
I'm glad to help with debugging and testing. I would prefer to use the git scm
as I am very used to the workflows there. However, I am not so great of a coder.
From my experience a new Gerbv release would heavily help non software engineering
people to use Gerbv, thus increase popularity. We had the same situation with KiCAD
which had no proper release for years but nightlies from different sources.
After the 4.0 release people actually knew what to use.
*YES*

Regards,

Clemens
--
As I stated during FOSDEM I’d be interested in helping on a new Gerbv release. As I’m quite new in this project, where should we start such a discussion? I could put some time in as my company heavily relies on Gerbv.
From my experience a new Gerbv release would heavily help non software engineering people to use Gerbv, thus increase popularity. We had the same situation with KiCAD which had no proper release for years but nightlies from different sources. After the 4.0 release people actually knew what to use.
Patrick
Post by Clemens Koller
Who is in charge which I can handle over a big broom here to update the websites and get rid of that old stuff?
I'll retest when I get a chance to rebuild it...
Maybe a better approach is: release early, release often?
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Gerbv-devel mailing list
https://lists.sourceforge.net/lists/listinfo/gerbv-devel
Sergey Alyoshin
2017-02-12 14:53:59 UTC
Permalink
Post by Clemens Koller
Hello, Patrick, Sergey!
As I stated during FOSDEM I’d be interested in helping on a new Gerbv release.
I've seen that one video as well... 8-)
As I’m quite new in this project, where should we start such a discussion?
Clemens and Patrick, help is always welcome, as in any free software project.

You can check README-release.txt file in gerbv source, and the main
problem (for me) is Win build with installer.
Ask for gerbv git and sf.net permissions in
Post by Clemens Koller
Hello, Patrick, Sergey!
As I stated during FOSDEM I’d be interested in helping on a new Gerbv release.
I've seen that one video as well... 8-)
As I’m quite new in this project, where should we start such a discussion?
You can check README-release.txt file in gerbv source, and the main
problem (for me) is Win build with installer.
Plus contact last translators (it is only me at current time) from
po/*.po and ask them to update translation.
Post by Clemens Koller
Here? Sergey, what do you think?
I'm glad to help with debugging and testing. I would prefer to use the git scm
as I am very used to the workflows there. However, I am not so great of a coder.
We are using git for gerbv.
Post by Clemens Koller
From my experience a new Gerbv release would heavily help non software engineering
people to use Gerbv, thus increase popularity. We had the same situation with KiCAD
which had no proper release for years but nightlies from different sources.
After the 4.0 release people actually knew what to use.
*YES*
Regards,
Clemens
--
As I stated during FOSDEM I’d be interested in helping on a new Gerbv release. As I’m quite new in this project, where should we start such a discussion? I could put some time in as my company heavily relies on Gerbv.
From my experience a new Gerbv release would heavily help non software engineering people to use Gerbv, thus increase popularity. We had the same situation with KiCAD which had no proper release for years but nightlies from different sources. After the 4.0 release people actually knew what to use.
Patrick
Post by Clemens Koller
Who is in charge which I can handle over a big broom here to update the websites and get rid of that old stuff?
About what old stuff we are speaking here?
-- gerbv-beta is just a build for Win with current fixes, as it is not
trivial to build GTK application for Win.
-- gerbv-2.6.1 is a last official release.
Post by Clemens Koller
Post by Clemens Koller
I'll retest when I get a chance to rebuild it...
Maybe a better approach is: release early, release often?
Only if you have plenty of active developers.
Valerio Messina
2017-02-12 21:57:13 UTC
Permalink
Post by Sergey Alyoshin
You can check README-release.txt file in gerbv source, and the main
problem (for me) is Win build with installer.
I already managed build a win git version for company internal use.
If the installer is NSIS based I can help here

Valerio
Clemens Koller
2017-02-13 09:09:27 UTC
Permalink
Hi, Valerio!
Post by Valerio Messina
I already managed build a win git version for company internal use.
If the installer is NSIS based I can help here
I could (not build but) test these in virtual WinXP, Win7 and Win10 machines.

Clemens
--
Post by Valerio Messina
Post by Sergey Alyoshin
You can check README-release.txt file in gerbv source, and the main
problem (for me) is Win build with installer.
I already managed build a win git version for company internal use.
If the installer is NSIS based I can help here
Valerio
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Gerbv-devel mailing list
https://lists.sourceforge.net/lists/listinfo/gerbv-devel
Uwe Bonnes
2017-02-13 09:49:03 UTC
Permalink
Post by Sergey Alyoshin
You can check README-release.txt file in gerbv source, and the main
problem (for me) is Win build with installer.
Valerio> I already managed build a win git version for company internal
Valerio> use. If the installer is NSIS based I can help here

Can you perhaps describe your setup?
--
Uwe Bonnes ***@elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 1623569 ------- Fax. 06151 1623305 ---------
Valerio Messina
2017-02-22 17:30:39 UTC
Permalink
Post by Uwe Bonnes
Can you perhaps describe your setup?
sorry for delay.

I had a working MSYS2 installation on Win7 64 bit.


The commands are the same as Linux build:

$ git clone git://git.geda-project.org/gerbv.git
$ sh autogen.sh
$ ./configure --enable-unit-mm --disable-update-desktop-database
$ make

Just tested the 5 minutes binary generation work.
The binary generated in ./src is:
38912 22 feb 18.22 gerbv.exe
$ file gerbv
gerbv: PE32+ executable (console) x86-64 (stripped to external PDB), for
MS Windows

running the exe, the About dialog shown:

This is gerbv version 2.6A
Compiled on Feb 22 2017 at 18:22:44

Valerio
Valerio Messina
2017-02-24 20:56:06 UTC
Permalink
the 64 bit executable work well inside MSYS2 Mingw64 shell only, as it
require all the 64 bit libraries version.
So I generated the 32 bit version with Mingw32 shell, and the binary in
src/.libs work very well with Gerbv 2.6.1 32 bit libraries, once added
the libgerbv*.dll and a single mingw supplied *gcc*.dll

For the 64 bit version I'm extracting the complete dll env to let Gerbv
work outside of mingw64 shell, and so we can prepare a 64 bit NSIS
distribution. If it is desired.

Valerio

Joerg Wunsch
2017-02-10 13:59:18 UTC
Permalink
Post by Clemens Koller
After a 90° rotation, the center points of some (rasterized) pads
gets transformed properly, but the pad orientation itself stays the
same which breaks things.
Are you working from a project file?

I've recently reported a bug and suggested a fix for that,
but I think I failed to eventually file my final version
of the fix. The issue with project files is that they offer
only a limited number of decimal digits for the rotation
value, so the check for whether the rotation is a multiple
of 90 degrees fails.

However, in my case, I got a complaint that the rotation
failed.
--
cheers, Joerg .-.-. --... ...-- -.. . DL8DTL

http://www.sax.de/~joerg/
Never trust an operating system you don't have sources for. ;-)
Clemens Koller
2017-02-13 19:19:57 UTC
Permalink
Hi, there!

I was able to test the latest git HEAD c0ea2b5.
The rotation issue seems to be fixed. My data rotates correctly. :-)

Regards,

Clemens
--
Post by Clemens Koller
Hi there!
I am currently reviewing some paste masks and want to rotate the board data containing some arbitrary pad shapes.
After a 90° rotation, the center points of some (rasterized) pads gets transformed properly, but the pad orientation itself
stays the same which breaks things.
If this happens, I would at least expect a warning that the design data may be corrupt after such a transformation.
Better would be a proper fix.
I could provide some test data. Is there anybody working on a fix already? I am willing to help to improve this part.
Regards,
Clemens
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Gerbv-devel mailing list
https://lists.sourceforge.net/lists/listinfo/gerbv-devel
Loading...